fix test to toggle panel open before using it

move toggle to commands helper file

move toggle to ui-panel helper file

added shouldToggle arg to runcommand

fix console tests

ui/tests/acceptance/console-test.js

@@ -25,8 +25,6 @@ module('Acceptance | console', function (hooks) {
     assert.expect(6);
     await enginesPage.visit();
     await settled();
-    await consoleComponent.toggle();
-    await settled();
     const ids = [uuidv4(), uuidv4(), uuidv4()];
     for (const id of ids) {
       const inputString = `write sys/mounts/console-route-${id} type=kv`;
@@ -59,7 +57,7 @@ module('Acceptance | console', function (hooks) {
   test('fullscreen command expands the cli panel', async function (assert) {
     await consoleComponent.toggle();
     await settled();
-    await consoleComponent.runCommands('fullscreen');
+    await consoleComponent.runCommands('fullscreen', false);
     await settled();
     const consoleEle = document.querySelector('[data-test-component="console/ui-panel"]');
     // wait for the CSS transition to finish
@@ -74,7 +72,7 @@ module('Acceptance | console', function (hooks) {
   test('array output is correctly formatted', async function (assert) {
     await consoleComponent.toggle();
     await settled();
-    await consoleComponent.runCommands('read -field=policies /auth/token/lookup-self');
+    await consoleComponent.runCommands('read -field=policies /auth/token/lookup-self', false);
     await settled();
     const consoleOut = document.querySelector('.console-ui-output>pre');
     // wait for the CSS transition to finish
@@ -86,7 +84,7 @@ module('Acceptance | console', function (hooks) {
   test('number output is correctly formatted', async function (assert) {
     await consoleComponent.toggle();
     await settled();
-    await consoleComponent.runCommands('read -field=creation_time /auth/token/lookup-self');
+    await consoleComponent.runCommands('read -field=creation_time /auth/token/lookup-self', false);
     await settled();
     const consoleOut = document.querySelector('.console-ui-output>pre');
     // wait for the CSS transition to finish
@@ -97,7 +95,7 @@ module('Acceptance | console', function (hooks) {
   test('boolean output is correctly formatted', async function (assert) {
     await consoleComponent.toggle();
     await settled();
-    await consoleComponent.runCommands('read -field=orphan /auth/token/lookup-self');
+    await consoleComponent.runCommands('read -field=orphan /auth/token/lookup-self', false);
     await settled();
     const consoleOut = document.querySelector('.console-ui-output>pre');
     // have to wrap in a later so that we can wait for the CSS transition to finish

ui/tests/helpers/commands.js

@@ -1,10 +1,11 @@
-import consoleClass from 'vault/tests/pages/components/console/ui-panel';
-import { create } from 'ember-cli-page-object';
 /**
  * Copyright (c) HashiCorp, Inc.
  * SPDX-License-Identifier: BUSL-1.1
  */
 
+import consoleClass from 'vault/tests/pages/components/console/ui-panel';
+import { create } from 'ember-cli-page-object';
+
 /**
  * Helper functions to run common commands in the consoleComponent during tests.
  * Please note that a user must be logged in during the test context for the commands to run.

ui/tests/integration/components/console/ui-panel-test.js

@@ -23,20 +23,21 @@ module('Integration | Component | console/ui panel', function (hooks) {
 
   test('it clears console input on enter', async function (assert) {
     await render(hbs`{{console/ui-panel}}`);
-
-    await component.runCommands('list this/thing/here');
+    await component.runCommands('list this/thing/here', false);
     await settled();
     assert.strictEqual(component.consoleInputValue, '', 'empties input field on enter');
   });
 
   test('it clears the log when using clear command', async function (assert) {
     await render(hbs`{{console/ui-panel}}`);
-
-    await component.runCommands(['list this/thing/here', 'list this/other/thing', 'read another/thing']);
+    await component.runCommands(
+      ['list this/thing/here', 'list this/other/thing', 'read another/thing'],
+      false
+    );
     await settled();
     assert.notEqual(component.logOutput, '', 'there is output in the log');
 
-    await component.runCommands('clear');
+    await component.runCommands('clear', false);
     await settled();
     await component.up();
     await settled();
@@ -51,7 +52,7 @@ module('Integration | Component | console/ui panel', function (hooks) {
   test('it adds command to history on enter', async function (assert) {
     await render(hbs`{{console/ui-panel}}`);
 
-    await component.runCommands('list this/thing/here');
+    await component.runCommands('list this/thing/here', false);
     await settled();
     await component.up();
     await settled();
@@ -67,8 +68,7 @@ module('Integration | Component | console/ui panel', function (hooks) {
 
   test('it cycles through history with more than one command', async function (assert) {
     await render(hbs`{{console/ui-panel}}`);
-
-    await component.runCommands(['list this/thing/here', 'read that/thing/there', 'qwerty']);
+    await component.runCommands(['list this/thing/here', 'read that/thing/there', 'qwerty'], false);
     await settled();
     await component.up();
     await settled();

ui/tests/integration/components/sidebar/frame-test.js

@@ -35,7 +35,7 @@ module('Integration | Component | sidebar-frame', function (hooks) {
     assert.dom('[data-test-sidebar-nav]').doesNotExist('Sidebar is hidden');
   });
 
-  test('it should render link status, console ui panel and yield block for app content', async function (assert) {
+  test('it should render link status, console ui panel container and yield block for app content', async function (assert) {
     const currentCluster = this.owner.lookup('service:currentCluster');
     currentCluster.setCluster({ hcpLinkStatus: 'connected' });
     const version = this.owner.lookup('service:version');
@@ -50,7 +50,7 @@ module('Integration | Component | sidebar-frame', function (hooks) {
     `);
 
     assert.dom('[data-test-link-status]').exists('Link status component renders');
-    assert.dom('[data-test-component="console/ui-panel"]').exists('Console UI panel renders');
+    assert.dom('[data-test-console-panel]').exists('Console UI panel container renders');
     assert.dom('.page-container').exists('Block yields for app content');
   });
 

ui/tests/pages/components/console/ui-panel.js

@@ -54,12 +54,18 @@ export default {
     eventProperties: { keyCode: keys.ENTER },
   }),
   hasInput: isPresent('[data-test-component="console/command-input"] input'),
-  runCommands: async function (commands) {
+  runCommands: async function (commands, shouldToggle = true) {
     const toExecute = Array.isArray(commands) ? commands : [commands];
+    if (shouldToggle) {
+      await this.toggle(); // toggle the console open
+    }
     for (const command of toExecute) {
       await this.consoleInput(command);
       await this.enter();
       await settled();
     }
+    if (shouldToggle) {
+      await this.toggle(); // toggle it closed
+    }
   },
 };