Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewTestLoggerWithSuffix for tests that need multiple log files #26879

Merged
merged 1 commit into from
May 9, 2024

Conversation

victorr
Copy link
Contributor

@victorr victorr commented May 8, 2024

Make it possible to add a suffix to the file used by TestLogger.

This feature is to be used a unit test in vault-enterprise.

@victorr victorr added this to the 1.17.0 milestone May 8, 2024
@victorr victorr requested a review from a team May 8, 2024 15:39
@victorr victorr self-assigned this May 8, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented May 8, 2024

Build Results:
All builds succeeded! ✅

@victorr victorr force-pushed the victorr/vault-25829-new-testlogger-constructor branch from 9200798 to e6934a6 Compare May 8, 2024 22:16
@victorr victorr force-pushed the victorr/vault-25829-new-testlogger-constructor branch from e6934a6 to e44871f Compare May 8, 2024 22:17
@victorr victorr requested a review from stevendpclark May 8, 2024 22:19
@victorr victorr enabled auto-merge (squash) May 9, 2024 13:38
@victorr victorr merged commit bfbc926 into main May 9, 2024
83 checks passed
@victorr victorr deleted the victorr/vault-25829-new-testlogger-constructor branch May 9, 2024 13:46
victorr added a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants