Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for engine paths in Secret Engine list view for configuration links #27131

Merged
merged 5 commits into from
May 21, 2024
Merged

Account for engine paths in Secret Engine list view for configuration links #27131

merged 5 commits into from
May 21, 2024

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented May 20, 2024 •
edited
Loading

backport/ent/1.15.x merge conflicts that are not worth the risk/reward of working around.
backport/1.16.x

  • ent test pass

BEFORE:

ldapbefore.mov

AFTER:

ldapafter.mov

@Monkeychip Monkeychip added the ui label May 20, 2024
@Monkeychip Monkeychip added this to the 1.17.0-rc milestone May 20, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip marked this pull request as ready for review May 20, 2024 19:51
@Monkeychip Monkeychip requested a review from a team as a code owner May 20, 2024 19:51
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

andaley
andaley approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@andaley andaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Monkeychip Monkeychip merged commit 89fc3bb into main May 21, 2024
31 checks passed
@Monkeychip Monkeychip deleted the ui/VAULT-20147/configuration-link-list-view branch May 21, 2024 14:20
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andaley andaley andaley approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.17.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@Monkeychip @andaley