Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Don't show resultant-ACL banner in nested namespace if ancestor wildcard policy into release/1.17.x #27291

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #27263 to be assessed for backporting due to the inclusion of the label backport/1.17.x.

The below text is copied from the body of the original PR.


This PR builds on the work from #26233. It hides the resultant-ACL banner if there are non-deny wildcard policies present for any ancestor of the current namespace. The changes in this PR are best illustrated through an example:

Example scenario
User Bob logs in at foo namespace and then navigates to namespace /foo/bar/baz. Bob has a policy with the following block:

path "bar/*" {
  capabilities = ["read", "update", "list"]
}

before, the wildcard calculation would determine the user does not have access because it was only checking a wildcard path at the user's relative root namespace (in this case, foo/). With this change, the wildcard calculation takes the current namespace foo/bar/baz and checks at each level if the Bob has wildcard access. The results are as follows:

  • foo/bar/baz/ ❌ no match

  • foo/bar/ ✅ match (exits loop)

  • Ent tests pass


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core requested a review from a team as a code owner May 30, 2024 19:30
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-27617/wildcard-access-nested-banner/strangely-touched-polecat branch from 081cdae to 2911976 Compare May 30, 2024 19:30
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 30, 2024
@hashishaw hashishaw added this to the 1.17.0 milestone May 30, 2024
…ccess-nested-banner/strangely-touched-polecat
Copy link

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw enabled auto-merge (squash) May 30, 2024 19:37
Copy link

github-actions bot commented May 30, 2024

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw merged commit a63cdd3 into release/1.17.x May 30, 2024
24 checks passed
@hashishaw hashishaw deleted the backport/ui/VAULT-27617/wildcard-access-nested-banner/strangely-touched-polecat branch May 30, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants