Mask obfuscated Secret sync create/edit fields #27348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
Monkeychip
commented
Jun 10, 2024
| @@ -247,7 +247,7 @@ | |||
| <MaskedInput | |||
| @name={{@attr.name}} | |||
| @value={{or (get @model this.valuePath) @attr.options.defaultValue}} | |||
| @allowCopy="true" | |||
| @allowCopy={{if @attr.options.noCopy false true}} | |||
There was a problem hiding this comment.
this should default to true. not ideal (rather it default to false) but working with an old pattern and trying to keep backporting/scope simple.
Monkeychip
changed the title
Monkeychip
commented
Jun 18, 2024
Monkeychip
commented
Jun 18, 2024
Monkeychip
commented
Jun 18, 2024
Monkeychip
commented
Jun 18, 2024
Monkeychip
changed the title
|
Build Results: |
hashishaw
approved these changes
Jun 18, 2024
| @@ -32,7 +32,7 @@ | |||
| aria-label={{or @name "masked input"}} | |||
| {{on "change" this.onChange}} | |||
| {{on "keyup" (fn this.handleKeyUp @name)}} | |||
| data-test-textarea | |||
| data-test-textarea={{or @name ""}} | |||
There was a problem hiding this comment.
I think we don't need or if the default is an empty string
Suggested change
| data-test-textarea={{or @name ""}} | |
| data-test-textarea={{@name}} |
There was a problem hiding this comment.
I thought that as well, but without the conditional it broke any test selector that didn't pass in a name. I suspect because it comes in as undefined?
| @@ -131,6 +131,28 @@ module('Integration | Component | sync | Secrets::Page::Destinations::CreateAndE | |||
| await click(PAGE.saveButton); | |||
| }); | |||
|
|
|||
| test('edit: payload only contains masked inputs when they have changed', async function (assert) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR masks while typing the obfuscated fields on the destinations create/edit form for Secrets sync. Screenshots for the changes are included on the file changes view.
Notes:
Not backporting to 1.17.x. This is a feature and too many changes to safely backport.
GCP json credentials field is the only param using the enable-input wrap and not the masked-input because it's not a simple one-to-one replacement and enable-input is doing a great job at handling it's use case.
Enterprise test pass
Tested that patch still works as expected. There used to be an issue where we'd send ** values if a obfuscated field had been changed previously and then not changed again. I will link to the internal JIRA ticket within slack.