Make mountsLock and authLock in Core configurable #27633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the mountsLock and authLock fields in the Core struct from
locking.DeadlockRWMutex
tolocking.RWMutex
. This change allows the fields to be set to eitherlocking.DeadlockRWMutex
orlocking.SyncRWMutex
(or any other type that fulfills thelocking.RWMutex
interface for that matter).These fields are now set using the
locking.CreateConfigurableRWMutex
function which selects thelocking.DeadlockRWMutex
implementation if the provided lock type name is present in the provided detectDeadlocks slice.The
detect_deadlocks
configuration parameter is used to specify which locks are configured to use thelocking.DeadlockRWMutex
. If a lock is not specified in that parameter, it is configured to use thelocking.SyncRWMutex
which is an alias forsync.RWMutex
.This PR has an accompanying ENT PR: https://github.com/hashicorp/vault-enterprise/pull/6163
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+ent
labelsinstead of the old style
backport/x.x.x
labels.the normal
backport/x.x.x
label (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.