-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: removeember-fetch
which used vulnerable version of rollup
#28575
Conversation
Build Results: |
CI Results: |
@@ -5,7 +5,7 @@ | |||
|
|||
import { module, test } from 'qunit'; | |||
import { setupRenderingTest } from 'vault/tests/helpers'; | |||
import { click, fillIn, render } from '@ember/test-helpers'; | |||
import { click, fillIn, render, waitFor, waitUntil } from '@ember/test-helpers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opted to use these helpers instead of adding helpers like @waitForPromise
to the rawRequest
functions in production code. Since testing-only helpers should really be avoided in production, if possible! https://www.npmjs.com/package/@ember/test-waiters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot's removed from the yarn lock. Did you delete it and rerun it to repopulate? Just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! Nope, this was just from uninstalling the package
Description
This is part 1 of resolving the
rollup
security vulnerability. There is no refactoring necessary because we can just use the native JS fetch method: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch which uses the same syntax✅ enterprise tests
![Screenshot 2024-10-02 at 3 11 42 PM](https://private-user-images.githubusercontent.com/68122737/373051913-b61ed076-d4b5-44b1-9267-105002235958.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODQ4MzgsIm5iZiI6MTczOTM4NDUzOCwicGF0aCI6Ii82ODEyMjczNy8zNzMwNTE5MTMtYjYxZWQwNzYtZDRiNS00NGIxLTkyNjctMTA1MDAyMjM1OTU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE4MjIxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiNjk4YjZkMDFkOWM1NWZmZjlhOTljYjZiMWUzMjJmZWRkZjIyZmVmMzAxYjNjOWI4ODAxNDQ2ZTA0YzAxNDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dwFcYqfwwqXd6n-yZ07tC0PTkY6iCpJG-K49gN4ebsE)
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+ent
labels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.x
label, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.