Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add usage metrics page #28723

Merged
merged 9 commits into from
Oct 18, 2024
Merged

[Docs] Add usage metrics page #28723

merged 9 commits into from
Oct 18, 2024

Conversation

yhyakuna
Copy link
Contributor

@yhyakuna yhyakuna commented Oct 16, 2024

Description

🧵 Slack thread

🔍 Deploy preview

🎫 Jira ticket

Although initial question was about what's new in Vault 1.18, the root issue was lack of information.

This PR adds "Usage metrics" page under Client count doc --> Content type is "How-to" guide

image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@yhyakuna yhyakuna self-assigned this Oct 16, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 16, 2024
@yhyakuna yhyakuna requested a review from schavis October 16, 2024 22:55
Copy link

CI Results:
All Go tests succeeded! ✅

@yhyakuna yhyakuna requested a review from lucymhdavies October 16, 2024 22:55
@yhyakuna yhyakuna marked this pull request as ready for review October 17, 2024 00:19
@yhyakuna yhyakuna requested a review from a team as a code owner October 17, 2024 00:19
Copy link

Build Results:
All builds succeeded! ✅

@lucymhdavies
Copy link
Contributor

Looks good. Can we get a little bit at the end with an example of what those CSV/JSONL files look like?

I can provide some examples from my own Vault if it helps.

@yhyakuna
Copy link
Contributor Author

yhyakuna commented Oct 17, 2024

Looks good. Can we get a little bit at the end with an example of what those CSV/JSONL files look like?

I can provide some examples from my own Vault if it helps.

@lucymhdavies Yes, if you have it handy, could you please send it to me. I'll add it to the doc. 🙏

On second thought, the API doc has sample response. That may be enough? So, I added the link to API docs.

@lucymhdavies
Copy link
Contributor

lucymhdavies commented Oct 18, 2024

aha! Yes, the API response example from https://developer.hashicorp.com/vault/api-docs/system/internal-counters#activity-export is perfect.

@yhyakuna yhyakuna merged commit a2390d3 into main Oct 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants