Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of VAULT-30877: Repopulate AWS static creds queue in initialize into release/1.18.x #28827

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28775 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

Closes #21935

Use the initialize function to re-populate the rotation queue on an active node. Store the credential's expiration value in storage and update it when it changes.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

Sorry, something went wrong.

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/miagilepner/VAULT-30877-aws-static-rotation-repopulate/physically-valued-grizzly branch from e7fcce9 to ced976a Compare November 4, 2024 15:32
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 4, 2024
@fairclothjm fairclothjm enabled auto-merge (squash) November 4, 2024 15:35
@fairclothjm fairclothjm added this to the 1.18.2 milestone Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Nov 4, 2024

Build Results:
All builds succeeded! ✅

@fairclothjm fairclothjm merged commit 74339e7 into release/1.18.x Nov 4, 2024
83 of 84 checks passed
@fairclothjm fairclothjm deleted the backport/miagilepner/VAULT-30877-aws-static-rotation-repopulate/physically-valued-grizzly branch November 4, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants