Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix bug setting PKI issuer enable_aia_url_templating to be set to false into release/1.18.x #28833

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core commented Nov 4, 2024

Backport

This PR is auto-generated from #28832 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

Fix bug setting PKI issuer enable_aia_url_templating to be set to false.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

Copy link

hashicorp-cla-app bot commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

CI Results:
All Go tests succeeded! ✅

@victorr victorr force-pushed the backport/victorr/vault-32137-fix-issuer-patch-enable-templating/hardly-helping-jawfish branch from 538fea2 to 37b9f82 Compare November 4, 2024 20:54
@victorr victorr marked this pull request as ready for review November 4, 2024 20:55
@victorr victorr requested a review from a team as a code owner November 4, 2024 20:55
@victorr victorr added this to the 1.18.2 milestone Nov 4, 2024
@victorr victorr enabled auto-merge (squash) November 4, 2024 20:59
Copy link

github-actions bot commented Nov 4, 2024

Build Results:
All builds succeeded! ✅

@victorr victorr merged commit 33ef079 into release/1.18.x Nov 4, 2024
90 of 104 checks passed
@victorr victorr deleted the backport/victorr/vault-32137-fix-issuer-patch-enable-templating/hardly-helping-jawfish branch November 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants