Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Decode Oracle database connection_url into release/1.18.x #29139

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #29114 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

We don't have any enterprise only plugins that I'm aware of, but ran enterprise tests just in case ✅

The API returns the oracle connection_url encoded, but for the UI to pass around data correctly (for viewing and editing) we need to decode it. While we added a helper a while ago to decode the url for display (#23695), submitting any updates to the connection failed because the form submitted the unencoded connection_url. Now when the request is returned from the server, we interrupt it and decode the uri.

API response

Screenshot 2024-12-05 at 3 53 09 PM

Failed save

Notice the unencoded url in the Connection URL input
Screenshot 2024-12-05 at 3 55 50 PM

With fix 🔧

Screenshot 2024-12-05 at 3 59 05 PM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/fix-oracle-connection-url-decoding/rarely-known-mammoth branch from c9eb0a0 to 1001329 Compare December 10, 2024 17:31
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 10, 2024
@hellobontempo hellobontempo added this to the 1.18.3 milestone Dec 10, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo merged commit 349fe58 into release/1.18.x Dec 10, 2024
32 of 33 checks passed
@hellobontempo hellobontempo deleted the backport/ui/fix-oracle-connection-url-decoding/rarely-known-mammoth branch December 10, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants