Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix updating static roles via role edit page on UI #29498

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

drivera258
Copy link
Contributor

@drivera258 drivera258 commented Feb 4, 2025

Description

Fixes UI bug when a user tries to update the rotation period for a static role via the UI

We now include the username of the role we're updating when making the post request instead of just the rotation period

✅ Ent tests pass

Before:

image

image

After:

Screen.Recording.2025-02-04.at.1.11.11.PM.mov

image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

CI Results:
All Go tests succeeded! ✅

@drivera258 drivera258 added this to the 1.19.0-rc milestone Feb 4, 2025
@drivera258 drivera258 added the ui label Feb 4, 2025
@drivera258 drivera258 marked this pull request as ready for review February 4, 2025 20:37
@drivera258 drivera258 requested review from a team as code owners February 4, 2025 20:37
@drivera258 drivera258 requested a review from ej-hashi February 4, 2025 20:37
Copy link

github-actions bot commented Feb 4, 2025

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Can you add a test, perhaps here, to assert the payload is what we expect when updating a static role?

ui/app/adapters/database/role.js Outdated Show resolved Hide resolved
ui/app/adapters/database/role.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants