Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token-only. #2971

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Add token-only. #2971

merged 2 commits into from
Jul 12, 2017

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Jul 4, 2017

Fixes #2855

@jefferai jefferai added this to the 0.7.4 milestone Jul 4, 2017
Copy link
Contributor

@chrishoffman chrishoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. My only question is should -token-only also imply -no-store? I know the flag could be set to disable storage but it seems to me the use case for -token-only would rarely, if ever, need the token to be stored.

@jefferai
Copy link
Member Author

jefferai commented Jul 5, 2017

@chrishoffman I had thought about that too, and wasn't sure. I guess it depends which problem is being solved:

  • The token is returned and stored in the token helper but the user doesn't understand where that is, so when they want to pass it into a script they don't know where to look
  • The token is never meant to be used locally and always passed on

I guess the former situation can be remedied by them simply passing the value back into vault auth if needed. So probably it should imply no-store. I'll make that change.

Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jefferai jefferai merged commit ef01088 into master Jul 12, 2017
@jefferai jefferai deleted the issue-2855 branch July 12, 2017 19:04
@martinssipenko
Copy link
Contributor

Nice, thanks!

@jefferai jefferai modified the milestones: 0.7.4, 0.8.0 Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants