Let AWS auth CLI helper only generate login data #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Jul 17, 2017
builtin/credential/aws/cli.go
Outdated
| } | ||
| // Generates the necessary data to send to the Vault server for generating a token | ||
| // This is useful for other API clients to use | ||
| func GenerateLoginData(accessKey, secretKey, sessionToken, headerValue string) (*map[string]interface{}, error) { |
There was a problem hiding this comment.
Same problem here -- don't need it to be a pointer!
This will be useful to other golang clients so they can manage the login process themselves. Also helps for hashicorp#2855
joelthompson
force-pushed
the
aws_iam_headers_helper
branch
from
b3687e0 to
9bae272
Compare
jefferai
approved these changes
Jul 18, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful to other golang clients so they can manage the login
process themselves.
I wasn't sure if I should put this here or in the api/ folder -- I feel like that might be more appropriate, but I don't want to force all API clients to pull in the AWS Go SDKs if they're not using them, so this seems like it might be a better place? Open to suggestions on where best to put this, if it makes sense to include.