Tests for setup plugin errors #3253
Conversation
vault/logical_system_integ_test.go
Outdated
| @@ -220,6 +273,28 @@ func testSystemBackendMock(t *testing.T, numMounts int, backendType logical.Back | |||
| return cluster | |||
| } | |||
|
|
|||
| func ensureCoresSealed(t *testing.T, c *vault.TestCluster) { | |||
There was a problem hiding this comment.
Can we maybe not have this function copied around somewhere yet again?
Let's start migrating such utility functions to a helper/testutil or so package.
There was a problem hiding this comment.
Moved to testing.go since its a TestCluster operation
| directoryPath := filepath.Dir(fullPath) | ||
|
|
||
| // Set core's plugin directory and plugin catalog directory | ||
| c.pluginDirectory = directoryPath |
There was a problem hiding this comment.
setupPluginCatalog() uses c.pluginDirectory. If there is a unseal process during the test, the plugin loads from an empty directory and plugin mount fails:
"core: failed to create mount entry: path=mock-0/ error=no plugin found with name: mock-plugin"
|
@briankassouf I think it's because this is not a merge to master. Travis should run when I open the PR on |
|
@calvn Ah, didn't notice that 👍 |
|
@jefferai I also changed |
|
I'd bump it back up. Other testing code (especially on ent side) can take quite a bit longer to finish up tasks before sealing. |
|
Bumped, merging if no objections. |
Also refactored
NewTestClusterto be able to create a cluster with an arbitrary number of cores.