Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cassandra tests, explicitly set cluster port if provided #3296

Merged
merged 8 commits into from
Sep 8, 2017
Merged

Fix cassandra tests, explicitly set cluster port if provided #3296

merged 8 commits into from
Sep 8, 2017

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Sep 6, 2017

The session created by gocql prioritizes *ClusterConfig.Port value over the port that is provided as part of the host, so we need to set it explicitly if one is provided.

@calvn calvn requested a review from briankassouf September 6, 2017 21:14
@calvn
Copy link
Contributor Author

calvn commented Sep 7, 2017 •
edited
Loading

Dug a bit into the gocql code and saw that c.CreateSession should handle splitting of host and port correctly. I suspect that a connection-related issue popped up because we are explicitly setting CASSANDRA_BROADCAST_ADDRESS which solves one issue, but introduced another. The Port option in ClusterConfig acts as the fallback/default port to use if none is specified in the host, so we shouldn't override.

@briankassouf
Copy link
Contributor

@calvn Can you add the port flag to the API docs?

@calvn calvn merged commit 38be344 into master Sep 8, 2017
@calvn calvn deleted the f-cassandra-tests branch September 8, 2017 15:10
chrishoffman pushed a commit that referenced this pull request Sep 8, 2017
Merge remote-tracking branch 'oss/master' into generic-to-kv
d4df8cb 
* oss/master:
  Handle errors from getRootConfig on aws logical backend (#3294)
  Fix cassandra tests, explicitly set cluster port if provided (#3296)
  Fix flag parsing on database plugins, exit on parse error (#3305)
  fix typo in policies documentation (#3302)
  Update vendored docker deps
  Fix docs for Certificate authentication (#3301)
  Fixed small typo in RabbitMQ secret backend. (#3300)
  Fix unauth bind issues due to lib update (#3293)
@chrishoffman chrishoffman mentioned this pull request Sep 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvn @briankassouf