Add the ability to use multiple paths for capability checking #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(tests, docs). Fixes #3336
jefferai
changed the title
vishalnayak
changed the title
calvn
reviewed
Feb 22, 2018
vault/logical_system.go
Outdated
| } | ||
|
|
||
| if len(paths) == 0 { | ||
| return nil, nil |
There was a problem hiding this comment.
Should we return a "paths not provided" or similar error in this case?
There was a problem hiding this comment.
Yes, it should. Fixed.
|
@vishalnayak I can't hit Approve on my own PR but I think this LGTM :-) Merge when you like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3336