Spelling #4119
Spelling #4119
Conversation
builtin/logical/database/backend.go
Outdated
| @@ -135,7 +135,7 @@ func (b *databaseBackend) DatabaseConfig(ctx context.Context, s logical.Storage, | |||
| type upgradeStatements struct { | |||
| // This json tag has a typo in it, the new version does not. This | |||
| // necessitates this upgrade logic. | |||
| CreationStatements string `json:"creation_statments"` | |||
| CreationStatements string `json:"creation_statements"` | |||
There was a problem hiding this comment.
[For others in the Vault team] This may not be required.
There was a problem hiding this comment.
In fact, this would break things because this is on purpose. The real question is, since this commit is automated, will the author respond to comments.
There was a problem hiding this comment.
There's a sleepy human behind this. I'll drop this
builtin/logical/database/backend.go
Outdated
| @@ -144,7 +144,7 @@ type upgradeStatements struct { | |||
| type upgradeCheck struct { | |||
| // This json tag has a typo in it, the new version does not. This | |||
| // necessitates this upgrade logic. | |||
| Statements upgradeStatements `json:"statments"` | |||
| Statements upgradeStatements `json:"statements"` | |||
There was a problem hiding this comment.
[For others in the Vault team] This may not be required.
| @@ -147,7 +147,7 @@ func TestBackend_RoleUpgrade(t *testing.T) { | |||
| } | |||
|
|
|||
| // Upgrade case | |||
| badJSON := `{"statments":{"creation_statments":"test","revocation_statements":"","rollback_statements":"","renew_statements":""}}` | |||
| badJSON := `{"statements":{"creation_statements":"test","revocation_statements":"","rollback_statements":"","renew_statements":""}}` | |||
There was a problem hiding this comment.
[For others in the Vault team] This may not be required.
|
@jefferai: dropped. fwiw, my general advice is to use things like: |
|
@jsoref that particular misspelling is in an upgrade path that's there specifically to migrate people from an original mistaken spelling to a fixed version :-) |
|
Looks good, thanks! |
Generated by https://github.com/jsoref/spelling
f; to maintain your repo, please considerfchurn