Shorten code by using ParseAddrs #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
previously approved these changes
May 10, 2018
briankassouf
previously approved these changes
May 10, 2018
| parsedCIDRs = append(parsedCIDRs, &sockaddr.SockAddrMarshaler{parsedCIDR}) | ||
| parsedCIDRs, err := parseutil.ParseAddrs(d.Get("bound_cidrs")) | ||
| if err != nil { | ||
| return logical.ErrorResponse(err.Error()), nil |
There was a problem hiding this comment.
This should still return logical.ErrInvalidRequest
There was a problem hiding this comment.
ErrInvalidRequest is the default!
https://github.com/hashicorp/vault/blob/master/logical/response_util.go#L90
There was a problem hiding this comment.
That was my oversight!
I don't think it would default to ErrInvalidRequest because here it's under a case statement rather than a default. https://github.com/hashicorp/vault/blob/master/logical/response_util.go#L106
There was a problem hiding this comment.
It would, because it starts at ErrInvalidRequest. If nothing modifies it, it will stay there. Since in this case nothing is modifying it...
tyrannosaurus-becks
dismissed stale reviews from briankassouf and jefferai
via
977e2d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.