Add entity information request to system view #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
reviewed
Jun 1, 2018
logical/identity.go
Outdated
| // Aliases contains the unique identifiers assigned by the | ||
| // auth methods | ||
| Aliases []*Alias `json:"aliases"` | ||
| } |
There was a problem hiding this comment.
Could we instead have this be a proto message here, that will remove the translations for plugins
kalafut
previously approved these changes
Jun 1, 2018
jefferai
reviewed
Jun 2, 2018
vault/dynamic_system_view.go
Outdated
| aliases := make([]*logical.Alias, len(entity.Aliases)) | ||
| for i, alias := range entity.Aliases { | ||
| aliases[i] = &logical.Alias{ | ||
| MountType: alias.MountType, |
There was a problem hiding this comment.
Aliases do not hold mount type, this value will always be blank from a pure lookup. See https://github.com/hashicorp/vault/blob/master/vault/identity_store_aliases.go#L451 for how to look it up in real time.
In theory for aliases it might be okay to store the type (just not the path). But if we have to look up the path anyways in real-time (since it can change) we are already getting the type...and we have had cases in the past where we've upgraded one type to another (e.g. aws-ec2 to aws) so it's safer.
jefferai
approved these changes
Jun 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.