Use varbinary instead of varchar for mysql, fixes #512 #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why tests are failing, they work fine locally on OS X and Linux. |
|
This LGTM, although I wonder if we should also provide a migration for those who have already been running Vault in production to change the column type. |
armon
added a commit
that referenced
this pull request
Aug 13, 2015
Use varbinary instead of varchar for mysql, fixes #512
|
Thanks! @sethvargo The MySQL backend is new, and it seems most people would have run into this if they tried to run into it. Not worth the effort, easy enough to do manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #512