Add ability to provide env vars to plugins #5359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5177
Only the former of the two options is implemented. The reasoning is the same behind separating the
command
andargs
params, which started off as being one and the same before getting split (and tagging the 2-in-1 option as deprecated). If users end up asking for the ability to pass in key=value pairs as part of the command then we can add it later, but this is more in line with howexec.Command
works.