UI - ent init #5428
UI - ent init #5428
Conversation
| </h1> | ||
| {{#with (or keyData.recovery_keys keyData.keys) as |keyArray|}} | ||
| <h1 class="title is-4"> | ||
| Vault has been initialized! {{#if (eq keyArray.length 1)}} |
There was a problem hiding this comment.
Any harm in moving the conditional to the next line?
There was a problem hiding this comment.
Nope! I'lld do that
| @@ -13,6 +13,7 @@ const DEFAULTS = { | |||
|
|
|||
| export default Controller.extend(DEFAULTS, { | |||
| wizard: service(), | |||
| model: null, | |||
There was a problem hiding this comment.
lol no, habit from components
| @@ -1,4 +1,3 @@ | |||
| import { computed } from '@ember/object'; | |||
| import { alias, and, equal } from '@ember/object/computed'; | |||
| import DS from 'ember-data'; | |||
| const { attr } = DS; | |||
There was a problem hiding this comment.
Unrelated, but you ought to be able to use modules for Ember Data as well now.
import Model from 'ember-data/model';
import attr from 'ember-data/attr';There was a problem hiding this comment.
Huh I guess the codemod doesn't do that?
There was a problem hiding this comment.
Oddly the guides still show the old way - gonna hold off on this now and do it all at once in a different PR.
| Here are your {{pluralize keyData.keys.length "key"}}. | ||
| {{/if}} | ||
| </h1> | ||
| {{#with (or keyData.recovery_keys keyData.keys) as |keyArray|}} |
There was a problem hiding this comment.
I believe with is deprecated in favor of let now.
There was a problem hiding this comment.
Ooo and it can yield multiple items 😙👌
| @stringify={{true}} | ||
| > | ||
| <DownloadButton @data={{keyData}} @filename={{keyFilename}} @mime="application/json" @extension="json" @class="button is-ghost" | ||
| @stringify={{true}}> |
There was a problem hiding this comment.
This is some weird formatting.
There was a problem hiding this comment.
Ugh yes js-beautify's default which VSCode uses does "break attrs only after max line length" by default - fixed it to break all attrs which is also kinda weird, but more easily read imo.
| @@ -157,4 +149,4 @@ | |||
| </form> | |||
| </Page.content> | |||
| {{/if}} | |||
| </SplashPage> | |||
| </SplashPage> | |||
There was a problem hiding this comment.
Intentional lack of newline or fallout from switching to VSCode 🤔
There was a problem hiding this comment.
😱 also another VSCode thing which I think I've fixed...
|
|
||
| test('cloud seal init', async function(assert) { | ||
| setInitResponse(this.server, CLOUD_SEAL_RESPONSE); | ||
| setStatusResponse(this.server, CLOUD_SEAL_STATUS_RESPONSE); |
There was a problem hiding this comment.
thanks! maybe overkill for 2 tests, but felt like it cleaned things up nicely
| @@ -34,7 +34,10 @@ export default { | |||
| onEntry: { type: 'render', level: 'feature', component: 'wizard/init-setup' }, | |||
| }, | |||
| save: { | |||
| on: { TOUNSEAL: 'unseal' }, | |||
| on: { | |||
| TOUNSEAL: 'unseal', | |||
There was a problem hiding this comment.
These look slightly weird, like they should have an _ in them, is this due to some sort of restriction, or just then way you've gone? (wheres a 🦭 🌊 emoji when you need one 😂)
There was a problem hiding this comment.
Ah yeah this was more keeping in line with what's there already - I'll make a note to add underscores later as we've got more work to do on the on boarding stuff.
|
Should these use one of the 'sensitive info toggle` components we have? Especially seeing as I might just want to download them without displaying them. |
|
@johncowen re: sensitive input - yep! but it needs to be reworked a bit. I actually tried adding it but there were some layout issues that weren't immediately obvious how to fix. We're going to be adding that in a lot more places for the next major release though. |
Though the UI started out at enterprise-only, it never had the ability to init any seals that weren't shamir-backed (the default if the
sealstanza is absent from the vault config). This PR enables initializing a Vault cluster using any of the documented seal types.The only visual difference is after you init, the message up top is a bit different because non-shamir seals will auto-unseal, and we now progress the user to Authenticate directly after init.
NOTE: This PR is dependent on the API change in #5424 to function properly - we need to know the seal type in order send the correct init parameters.