make list-item component more flexible and use hasMenu to optionally …

…render the menu

ui/app/components/list-item.js

@@ -7,7 +7,7 @@ export default Component.extend({
   tagName: '',
   linkParams: null,
   componentName: null,
-  hasMenu: false,
+  hasMenu: true,
 
   callMethod: task(function*(method, model, successMessage, failureMessage, successCallback = () => {}) {
     let flash = this.get('flashMessages');

ui/app/components/list-item/popup-menu.js

@@ -2,4 +2,6 @@ import Component from '@ember/component';
 
 export default Component.extend({
   tagName: '',
+  item: null,
+  hasMenu: null,
 });

ui/app/routes/vault/cluster/secrets/backend/secret-edit.js

@@ -140,16 +140,16 @@ export default Route.extend(UnloadModelRoute, {
     },
 
     willTransition(transition) {
-      let model = this.controller.model;
+      let { mode, model } = this.controller;
       let version = model.get('selectedVersion');
       let changed = model.changedAttributes();
       let changedKeys = Object.keys(changed);
       // until we have time to move `backend` on a v1 model to a relationship,
       // it's going to dirty the model state, so we need to look for it
       // and explicity ignore it here
       if (
-        (changedKeys.length && changedKeys[0] !== 'backend') ||
-        (version && Object.keys(version.changedAttributes()).length)
+        (mode !== 'show' && (changedKeys.length && changedKeys[0] !== 'backend')) ||
+        (mode !== 'show' && version && Object.keys(version.changedAttributes()).length)
       ) {
         if (
           window.confirm(

ui/app/styles/core/helpers.scss

@@ -4,12 +4,18 @@
 .is-underline {
   text-decoration: underline;
 }
+.is-no-underline {
+  text-decoration: none;
+}
 .is-sideless {
   box-shadow: 0 2px 0 -1px $grey-light, 0 -2px 0 -1px $grey-light;
 }
 .is-bottomless {
   box-shadow: 0 -1px 0 0 $grey-light;
 }
+.has-bottom-shadow {
+  box-shadow: $box-shadow !important;
+}
 .is-borderless {
   border: none !important;
 }

ui/app/templates/components/list-item.hbs

@@ -3,33 +3,27 @@
 {{else if linkParams}}
   <LinkedBlock @params={{linkParams}} @class="list-item-row">
     <div class="level is-mobile">
-      <div class="level-left">
-        <div>
-          {{#link-to params=linkParams class="has-text-weight-semibold"}}
-            {{yield (hash content=(component "list-item/content"))}}
-          {{/link-to}}
-        </div>
-      </div>
+      <div class="level-left is-flex-1">
+        {{#link-to params=linkParams class="has-text-weight-semibold has-text-black is-display-flex is-flex-1 is-no-underline"}}
+          {{yield (hash content=(component "list-item/content"))}}
+        {{/link-to}}
+    </div>
       <div class="level-right">
         <div class="level-item">
-          {{#if hasBlock}}
-            {{yield (hash callMethod=callMethod menu=(component "list-item/popup-menu"))}}
-          {{/if}}
+          {{yield (hash callMethod=callMethod menu=(component "list-item/popup-menu" item=item hasMenu=hasMenu))}}
         </div>
       </div>
     </div>
   </LinkedBlock>
 {{else}}
   <div class="list-item-row">
     <div class="level is-mobile">
-      <div class="level-left">
-        <div class="has-text-grey has-text-weight-semibold">
-          {{yield (hash content=(component "list-item/content"))}}
-        </div>
+      <div class="level-left is-flex-1 has-text-weight-semibold">
+        {{yield (hash content=(component "list-item/content"))}}
       </div>
       <div class="level-right">
         <div class="level-item">
-            {{yield (hash callMethod=callMethod menu=(component "list-item/popup-menu"))}}
+            {{yield (hash callMethod=callMethod menu=(component "list-item/popup-menu" item=item hasMenu=hasMenu))}}
         </div>
       </div>
     </div>

ui/app/templates/components/list-item/popup-menu.hbs

@@ -1,7 +1,11 @@
-<PopupMenu>
-  <nav class="menu">
-    <ul class="menu-list">
-      {{yield item}}
-    </ul>
-  </nav>
-</PopupMenu>
+{{#if hasMenu}}
+  <PopupMenu>
+    <nav class="menu">
+      <ul class="menu-list">
+        {{yield item}}
+      </ul>
+    </nav>
+  </PopupMenu>
+{{else}}
+  {{yield item}}
+{{/if}}

ui/app/templates/partials/secret-list/item.hbs

@@ -52,13 +52,17 @@
                       Details
                     </SecretLink>
                   </li>
-                  {{!--  // will add a link to the history view once it exists
                   {{#if backendModel.isV2KV}}
                     <li class="action">
-                      Verion History
+                      <SecretLink
+                        @mode="versions"
+                        @secret={{item.id}}
+                        @class="has-text-black has-text-weight-semibold"
+                      > 
+                        View version history
+                      </SecretLink>
                     </li>
                   {{/if}}
-                  --}}
                 {{/if}}
                 {{#if item.canEdit}}
                   <li class="action">