UI/gate wizard #6094
Merged
UI/gate wizard #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaley
force-pushed
the
ui/gate-wizard
branch
from
68e575d to
daa16c8
Compare
andaley
commented
Jan 25, 2019
johncowen
previously approved these changes
Jan 25, 2019
andaley
force-pushed
the
ui/gate-wizard
branch
from
fa08741 to
991e291
Compare
meirish
reviewed
Jan 28, 2019
meirish
reviewed
Jan 28, 2019
meirish
reviewed
Jan 28, 2019
| @@ -108,33 +108,53 @@ export default Service.extend({ | |||
| } | |||
| }, | |||
|
|
|||
| hasPermission(pathName) { | |||
| hasPermission(pathName, capabilities = [null]) { | |||
There was a problem hiding this comment.
setting capabilities as [] caused the tests to fail & incorrectly show items because calling .every on an empty array returned true. javascript! 🤷♀️
There was a problem hiding this comment.
huh guess I haven't used every/some enough to realize that - thanks!
meirish
reviewed
Jan 28, 2019
meirish
reviewed
Jan 28, 2019
meirish
previously approved these changes
Jan 28, 2019
andaley
force-pushed
the
ui/gate-wizard
branch
from
991e291 to
d85c709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only display onboarding wizard sections that the user has access to
Testing
If a user has full capabilities but has not selected anything, all sections should be enabled but the start button should be disabled.
Once they select something, the start button should be enabled.
If a user has no capabilities, all sections should be disabled with a tooltip on hover.
