Fix leader info repopulation #6167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change how we populate and clear leader UUID. This fixes a case where if a standby disconnects from an active node and reconnects, without the active node restarting, the UUID doesn't change so triggers on a new active node don't get run. * Add a bunch of test helpers and minor updates to things.
tyrannosaurus-becks
previously approved these changes
Feb 5, 2019
| import "golang.org/x/crypto/blake2b" | ||
|
|
||
| func Blake2b256Hash(key string) []byte { | ||
| hf, _ := blake2b.New256(nil) |
There was a problem hiding this comment.
The error being dropped here made me a little nervous at first, but I played with it and tested it out and agree that's the way to go.
briankassouf
reviewed
Feb 5, 2019
briankassouf
reviewed
Feb 5, 2019
| @@ -108,28 +108,41 @@ func (c *Core) Leader() (isLeader bool, leaderAddr, clusterAddr string, err erro | |||
| return false, "", "", nil | |||
| } | |||
|
|
|||
| c.clusterLeaderParamsLock.RLock() | |||
| localLeaderUUID := c.clusterLeaderUUID | |||
There was a problem hiding this comment.
Can we now remove these values from Core?
briankassouf
previously approved these changes
Feb 5, 2019
jefferai
dismissed stale reviews from briankassouf and tyrannosaurus-becks
via
1b68542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how we populate and clear leader UUID. This fixes a case where
if a standby disconnects from an active node and reconnects, without the
active node restarting, the UUID doesn't change so triggers on a new
active node don't get run.
Add a bunch of test helpers and minor updates to things.