reset pageFilter when the model changes #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
force-pushed
the
ui-reset-pageFilter
branch
from
edd2b9c to
0529fae
Compare
meirish
force-pushed
the
ui-reset-pageFilter
branch
from
1ad02f2 to
e933625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when navigating secrets via the filter input, the
pageFilterquery param is "sticky" - while this is the default behavior in Ember, this can be surprising when you are redirected or navigate to a list, only to find that a filter is still applied.This PR changes the secret list routes so that pageFilter gets reset when the model changes resulting in unfiltered lists when when navigating through the tree.