UI: Fix select arrow #6627
Merged
UI: Fix select arrow #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
reviewed
Apr 24, 2019
ui/app/styles/core/forms.scss
Outdated
| content: ''; | ||
| transform: translateY(-70%) rotate(135deg); | ||
| z-index: 5; | ||
| background-image: url('data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjQiIGhlaWd\ |
There was a problem hiding this comment.
You could use the svg-uri helper here so that the SVG code is still readable - here's an example of it:
There was a problem hiding this comment.
That's amazing. Updated.
joshuaogle
force-pushed
the
ui-fix-select-arrow
branch
from
a6d6aff to
2db3653
Compare
meirish
reviewed
Apr 29, 2019
| transform: translateY(-70%) rotate(135deg); | ||
| z-index: 5; | ||
| content: svg-uri( | ||
| '<svg width="24" height="24" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="M12 5.83L15.17 9l1.41-1.41L12 3 7.41 7.59 8.83 9 12 5.83zm0 12.34L8.83 15l-1.41 1.41L12 21l4.59-4.59L15.17 15 12 18.17z" fill="currentColor"/></svg>' |
meirish
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have fixed this issue before, but somehow it crept back in again. This adds in the Structure icon with a data url rather than rebuilding it with CSS borders. This solution has fewer moving parts to override the default Bulma styles, and should be more resilient.
Before:
After:
