Set chunkSize when creating a new GCS backend #6655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the chunkSize on the GCS Backend in
New
and adds a small regression test toTestBackend
.Rationale
I was taking a look at the GCS physical backend code and noticed that
chunkSize
was being parsed and checked but never set on the actual backend inNew
. Looking through the commit history, it appears thatchunkSize
was originally a package level variable but was later changed to a parameter within the Backend but it was never wired up inside ofNew
.Tests
To verify I wasn't crazy, I ran the new test before changing the
New
func:After setting the chunkSize in
New
the tests are all green: