-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http timeout values are configurable #6666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
alex/configurable-http-server-timeouts
branch
2 times, most recently
from
May 3, 2019 01:09
62698c9
to
f367e97
Compare
ghost
marked this pull request as ready for review
May 3, 2019 01:13
ghost
changed the title
sharing work
http timeout values are configurable
May 3, 2019
ghost
requested a review
from briankassouf
May 3, 2019 01:13
ghost
force-pushed
the
alex/configurable-http-server-timeouts
branch
from
May 3, 2019 01:14
f367e97
to
a8c1459
Compare
jefferai
reviewed
May 3, 2019
jefferai
reviewed
May 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the one comment.
ghost
force-pushed
the
alex/configurable-http-server-timeouts
branch
from
May 6, 2019 16:04
a8c1459
to
95ec131
Compare
jefferai
previously approved these changes
May 6, 2019
fixes #6007 |
briankassouf
previously approved these changes
May 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Just needs docs, those can come in a follow on PR if you want
briankassouf
approved these changes
May 10, 2019
ghost
deleted the
alex/configurable-http-server-timeouts
branch
May 10, 2019 17:41
briankassouf
pushed a commit
that referenced
this pull request
Jun 4, 2019
* http timeout fields are configurable * move return statement for server config tests outside of range loop * adds documentation for configurable listener http_* values * fixed some formatting for the docs markdown
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.