Combined Database backend: Add Static Account support to MongoDB #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Jun 28, 2019
calvn
reviewed
Jun 28, 2019
calvn
reviewed
Jun 28, 2019
briankassouf
reviewed
Jul 3, 2019
briankassouf
previously approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6970, this PR adds support for Static Accounts (introduced in #6834 , modified in #6951) to the MongoDB database plugin.
Unlike MySQL or PostgreSQL, MongoDB does not make use of
rotation_statements. The SDK supports changing the password directly, as opposed to other SQL type databases where the password is modified via an SQL statement.I added
TestMongoDB_SetCredentialsto the MongoDB plugin for testingSetCredentialsdirectly, andTestBackend_StaticRole_Rotations_MongoDBto the database rotation tests to verify rotations being handled correctly.