Escape SQL username and password parameters before substituting them into a URL #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
approved these changes
Jul 8, 2019
calvn
reviewed
Jul 8, 2019
| // Connection() uses sql.Open uses lib/pq uses net/url.Parse | ||
| u, err := url.Parse(sql.ConnectionURL) | ||
| if err != nil { | ||
| t.Errorf("URL parse error on %q %q: %+v", tc.Username, tc.Password, err) |
There was a problem hiding this comment.
Can we change these to t.Fatalf() to fail fast?
calvn
approved these changes
Jul 8, 2019
|
Whoops didn't refresh after Jeff merged.. |
| {"postgres", "pass/word"}, | ||
| {"postgres", "p@ssword"}, | ||
| {"postgres", "pass\"word\""}, | ||
| // Much to my surprise, CREATE USER "{{password}}" PASSWORD 'foo' worked. |
There was a problem hiding this comment.
PG treats anything quoted as a literal and literals can be used for roles and database names.
This was referenced Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer reported an issue where they could not use "password{0}" as a password in a Postgres connection.