Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS credential plugin maintenance #7114

Merged
merged 4 commits into from
Jul 31, 2019
Merged

Conversation

tyrannosaurus-becks
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks commented Jul 12, 2019

I am about to start working on #5844 , and I noticed that this plugin could use some updates.

This PR places functions that create paths paths on the backend rather than passing the backend into them. This makes sense because a) they're only used by the backend, and b) a path is something the backend has, so it jives with OOP. We also do it elsewhere now as the standard practice.

This also strips redundant field type declarations like the &Object below, which is no longer preferred in Go:

map[string]*Object {
    "first_thing": &Object{"something"},
}

This also replaces deprecated fields. Vault's implementation of OpenAPI has deprecated the Callbacks field in favor of Operations. AWS has deprecated session.New (which doesn't return an error) in favor of session.NewSession.

I also fixed a couple of minor linting issues along the way.

@tyrannosaurus-becks
Copy link
Contributor Author

Build failure appears unrelated.

Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, LGTM! 👍

@tyrannosaurus-becks tyrannosaurus-becks merged commit 0c9f8a3 into master Jul 31, 2019
@chrishoffman chrishoffman modified the milestones: near-term, 1.3 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants