Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to go1.12.12 on machine executors #7703

Merged
merged 12 commits into from
Nov 6, 2019
Merged

Conversation

samsalisbury
Copy link
Contributor

@samsalisbury samsalisbury commented Oct 21, 2019

This brings in recent changes from the release/1.2.x branch, as a single commit. It means that we are no longer using the Docker go executors, but are using a single machine executor for all Go jobs. This means we are also turning off Go Modules support for now, as has already been done in Enterprise, until we are ready to fully support it. After this change, all dependencies must be vendored, until we officially support using modules.

This change also means that we have a uniform build environment for both general CI and building releases, so we should see consistent results.

- This brings in recent ci changes from the release/1.2.x branch.
@samsalisbury samsalisbury requested a review from jefferai October 21, 2019 13:52
mjarmy
mjarmy previously approved these changes Oct 25, 2019
Copy link
Contributor

@mjarmy mjarmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the one minor observation

@samsalisbury samsalisbury merged commit 8dcf312 into master Nov 6, 2019
@samsalisbury samsalisbury deleted the golang1.12.12 branch November 6, 2019 13:15
catsby added a commit that referenced this pull request Nov 6, 2019
* origin/master: (90 commits)
  Port OSS changes from perf standby fix (#7818)
  Clarify language around 472 (#7814)
  Revert change suggested by vet. See the comment for details. (#7815)
  Document secondary activation public key endpoints/params (#7810)
  debug: check for nil secret on replication status response before accessing secret.Data (#7811)
  Update Azure storage docs (#7808)
  changelog++
  ci: switch to go1.12.12 on machine executors (#7703)
  website: Homepage updates, use case pages, navigation changes (#7782)
  Help text: update token create help about id value (#7792)
  changelog++
  changelog++
  Update API to use lease_id in body of sys/leases/revoke call (#7777)
  changelog++
  Don't allow registering a non-root zero TTL token lease (#7524)
  Update go-metrics (#7794)
  Update go-metrics in sdk (#7795)
  doc: remove comma from list.html.md (#7766)
  Update azure secrets plugin (#7788)
  Update helm.html.md (#7310)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants