To CONTRIBUTING.md, add PR instructions #8067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Closing this since it was an idea I had and I was curious if there'd be an appetite for it. Looks like there's not, and I'm totally cool with that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #8068
This PR is simply to add some "How to PR" instructions to our CONTRIBUTING.md file, which is shown to anyone doing a first-time PR. I implemented this on the Terraform Vault Provider and it turned out really nicely, I got a much higher percentage of PRs that were 100% ready to go on the first pass of the review. Seems like it might be useful here too.