Add identity templating helper to sdk/framework #8088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Jan 3, 2020
sdk/framework/identity_test.go
Outdated
| MountAccessor: "test_mount", | ||
| MountType: "secret", | ||
| Metadata: map[string]string{ | ||
| "alias-metadata": "metadata-value", |
There was a problem hiding this comment.
Better to use a different value than "metadata-value" in the three places it occurs? Would reduce ambiguity in test case expected values.
ncabatoff
reviewed
Jan 3, 2020
ncabatoff
reviewed
Jan 3, 2020
sdk/plugin/pb/backend.proto
Outdated
| @@ -594,6 +599,10 @@ service SystemView { | |||
|
|
|||
| // PluginEnv returns Vault environment information used by plugins | |||
| rpc PluginEnv(Empty) returns (PluginEnvReply); | |||
|
|
|||
| // GroupsForEntity returns the group membersship information for the given | |||
ncabatoff
previously approved these changes
Jan 3, 2020
ncabatoff
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.