Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB root rotation replication issue #8106

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

michelvocks
Copy link
Contributor

Related PR #8105

Fixes a bug that allows secondaries/performance standby's to rotate root DB credentials.

@michelvocks michelvocks added this to the 1.4 milestone Jan 7, 2020
@michelvocks michelvocks requested a review from catsby January 7, 2020 16:09
@briankassouf
Copy link
Contributor

Maybe we should get this merged so it can be used here and in your other PR? #7175

@kalafut
Copy link
Contributor

kalafut commented Jan 7, 2020

#7175 is now merged.

@michelvocks michelvocks force-pushed the fix_db_root_rotate_replication_issue branch from 8292d96 to 63e0ae8 Compare January 8, 2020 10:25
@michelvocks
Copy link
Contributor Author

Thanks @kalafut & @briankassouf! Done

Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@briankassouf
Copy link
Contributor

I think we should get this in for 1.3.2

@briankassouf briankassouf modified the milestones: 1.4, 1.3.2 Jan 8, 2020
@michelvocks michelvocks merged commit 45adc78 into master Jan 9, 2020
@michelvocks michelvocks deleted the fix_db_root_rotate_replication_issue branch January 9, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants