Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show permissions error on KV when you don't have access to create a secret #8133

Merged
merged 10 commits into from
Jan 15, 2020
Merged

Show permissions error on KV when you don't have access to create a secret #8133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6d3a74a
add catch for fail on save. isError is not being set to true, so set…
Monkeychip Jan 10, 2020
65951f4
add conditionally to only catch 403 permission errors. Otherwise it …
Monkeychip Jan 10, 2020
a2b3ab5
add in code comment
Monkeychip Jan 10, 2020
844808c
remove catch and pass version 2 secret model to Error handler inside …
Monkeychip Jan 13, 2020
e75371e
replace Error model with modelForData to catch errors on the correct …
Monkeychip Jan 14, 2020
a4ab4b0
add back in space
Monkeychip Jan 14, 2020
2dbed18
replace error model with modelForData
Monkeychip Jan 14, 2020
abe8889
Merge branch 'master' into VLTF-144-showPermissionsError-on-kv-create
Monkeychip Jan 14, 2020
ea6781a
Merge branch 'VLTF-144-showPermissionsError-on-kv-create' of github.c…
Monkeychip Jan 14, 2020
34ca78b
Merge branch 'master' into VLTF-144-showPermissionsError-on-kv-create
Monkeychip Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/app/templates/partials/secret-form-create.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<form class="{{if showAdvancedMode 'advanced-edit' 'simple-edit'}}" onsubmit={{action "createOrUpdateKey" "create"}}>
<div class="field box is-fullwidth is-sideless is-marginless">
<NamespaceReminder @mode="create" @noun="secret" />
<MessageError @model={{model}} @errorMessage={{error}} />
<MessageError @model={{modelForData}} @errorMessage={{error}} />
<label class="is-label" for="kv-key">Path for this secret</label>
<p class="control is-expanded">
{{input
Expand Down
2 changes: 1 addition & 1 deletion ui/app/templates/partials/secret-form-edit.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<form onsubmit={{action "createOrUpdateKey" "update"}}>
<div class="box is-sideless is-fullwidth is-marginless is-paddingless">
<MessageError @model={{model}} @errorMessage={{error}} />
<MessageError @model={{modelForData}} @errorMessage={{error}} />
<NamespaceReminder @mode="edit" @noun="secret" />
{{#if (and (not model.failedServerRead) (not model.selectedVersion.failedServerRead) (not-eq model.selectedVersion.version model.currentVersion))}}
<div class="form-section">
Expand Down