Strip unnecessary payload in AD root cred rotation example #8160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalafut
previously approved these changes
Jan 15, 2020
|
Thanks! When it's time to merge it, I'll also strip the payload from here, Jason pointed it out. |
tyrannosaurus-becks
dismissed stale reviews from kalafut and jasonodonnell
via
f1800ea
catsby
added a commit
that referenced
this pull request
Jan 21, 2020
* master: (34 commits) Use Shamir as KeK when migrating from auto-seal to shamir (#8172) changelog++ ssh backend: support at character in role name (#8038) Fix typo in YAML markup (#8194) Fix typo (#8192) Fix k8s injector examples (#8179) update dependencies, patch nextjs config (#8184) Strip unnecessary payload in AD root cred rotation example (#8160) New Website! (#8154) Update CHANGELOG.md changelog++ Fix panic when listener fails to startup (#8174) Create network layer abstraction to allow in-memory cluster traffic (#8173) Update test var name and tidy Factor out mysqlhelper so we can create mysql docker containers in other tests. (#8167) changelog++ changelog++ Pull wrapping creation to a var (#8137) ldap, okta: fix renewal when login policies are empty (#8072) Update CHANGELOG.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge after #8154 is in and I've updated the change to match.