Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlibabaCloud physical backend: clean code, fix tests #8186

Merged
merged 1 commit into from
Jan 30, 2020
Merged

AlibabaCloud physical backend: clean code, fix tests #8186

merged 1 commit into from
Jan 30, 2020

Conversation

vvelikodny
Copy link
Contributor

  • move duplicated names to constants
  • improve error handling for test

@vvelikodny vvelikodny force-pushed the clean-alibaba-physical-backend-code branch from 63b0abf to 38ba546 Compare January 18, 2020 01:44
@vvelikodny vvelikodny requested a review from kalafut January 19, 2020 21:17
kalafut
kalafut approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kalafut kalafut merged commit 8d46856 into hashicorp:master Jan 30, 2020
catsby added a commit that referenced this pull request Feb 4, 2020
@catsby
Merge branch 'b-fix-mysql-lock-panic' of github.com:hashicorp/vault i…
575c967 
…nto b-fix-mysql-lock-panic

* 'b-fix-mysql-lock-panic' of github.com:hashicorp/vault: (52 commits)
  Fix minor typo in doc string (#8277)
  Update gen_openapi.sh (#8273)
  update dependencies (#8271)
  docs: update vault k8s to 0.2.0 (#8269)
  Fix flaky test of api renewer by moving away from legacy api. (#8265)
  Clean AlibabaCloud physical backend code (#8186)
  Update GH issue template to point to forum (#8226)
  Fix default max_open_connections for db plugins (#8262)
  Fix broken link (#8259)
  Removing timing-dependent aspects of test. (#8261)
  Changelog++
  Added flag to disable X-Vault-Token header proxy if client passes the token (#8101)
  changelog++
  changelog++
  test: fix TestAgent_Template_Basic (#8257)
  docs: fix api path for merge entity identity doc (#8258)
  Bump etcd client API dep (#8037)
  Add Consul TLS options to access API endpoint (#8253)
  Docs: Add nomad TLS options (#8254)
  Update CHANGELOG.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalafut kalafut kalafut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvelikodny @kalafut