Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ui/dr primary/initial page setup #8671
Ui/dr primary/initial page setup #8671
Changes from all commits
5889b66
31763ba
401cf42
0bdd119
2fb3ce2
bc88fcd
dae8214
a2d9205
711e7d8
f8add4a
e6f391e
493e9f3
8802824
13f93de
05dd9f9
2c68ccf
2228b83
0de0494
2b20452
3d40297
5cb3fb7
a379a3e
d7c51e8
8aa0442
403ad11
228d100
376e989
7806198
4e4c848
161bf47
677ece9
9cb8f3f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see anything about default value best practices online from a quick search, but I'm wondering about whether we have any best practices around when to use a
null
default value as opposed a default value with the correct type (so here it would be an empty string). Any thoughts around that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, that's a great question! so far i've followed the pattern i've seen in our app with using
null
as an empty value. i think we do that partially to prevent any unintended side effects that could come from calling stuff on an empty string. i don't feel strongly either way though -- would you find it helpful if we moved to setting default values with the correct type?