Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent/template: update consul-template dep #9044

Merged
merged 1 commit into from
May 20, 2020

Conversation

jasonodonnell
Copy link
Contributor

A race condition exists when exit_after_auth: true is enabled with Agent templating where Agent doesn't wait for all commands to finish before exiting. This was due to CT sending a done signal for all templates being rendered. This has been fixed upstream in this commit hashicorp/consul-template#1370.

In newer version of CT, Name was removed from the configuration struct, so I removed it from Vault Agent.

@jasonodonnell jasonodonnell requested a review from a team May 20, 2020 15:33
@briankassouf briankassouf added this to the 1.4.2 milestone May 20, 2020
@jasonodonnell jasonodonnell merged commit dbaa9ec into master May 20, 2020
@jasonodonnell jasonodonnell deleted the fix-consul-template-race branch May 20, 2020 17:03
@mladlow mladlow modified the milestones: 1.4.2, 1.5 May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants