Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity and alias counts #9262

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Entity and alias counts #9262

merged 6 commits into from
Jun 24, 2020

Conversation

mgritter
Copy link
Contributor

This implements the vault.identity.entity.count and vault.identity.entity.alias.count metrics; initializing the gauge collection process is dependent on merging the previous PRs so we can do it all in core_metrics.go instead of core.go.

@mgritter mgritter added this to the 1.5 milestone Jun 19, 2020
Base automatically changed from kv_secret_gauges_1 to master June 19, 2020 19:01
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgritter mgritter merged commit 72752ca into master Jun 24, 2020
@mgritter mgritter deleted the entity_gauges_1 branch June 24, 2020 00:46
catsby added a commit that referenced this pull request Jun 24, 2020
* master:
  Entity and alias counts (#9262)
  Token gauge metrics implementation. (#9239)
  mfa: fix import path on test file (#9303)
  doc: update vault helm enterprise image examples (#9299)
  raft: add support for using backend for ha_storage (#9193)
  Document new and previously undocumented telemetry metrics: (#9283)
  Improve the performance of snapshot installs by using rename (#9247)
  docs: add additional info around transform for tweak and template type (#9203)
  Update CHANGELOG.md
  CL++: Add go version to server message output
andaley pushed a commit that referenced this pull request Jul 17, 2020
* Added gauge collectors for entity counts.
* Entity and alias gauges.
* Locking around accessor to core.identityStore and core.mount.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants