physical/gcs: use separate client for updating locks #9424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
commented
Jul 8, 2020
|
|
||
| // Client | ||
| opts := []option.ClientOption{option.WithUserAgent(useragent.String())} | ||
| if credentialsFile := c["credentials_file"]; credentialsFile != "" { |
There was a problem hiding this comment.
This has been deprecated for a very, very long time.
There was a problem hiding this comment.
@kalafut this might be fine to remove since we've had this notice for ~2yrs, but we should call this out in the changelog.
|
Tests: |
calvn
approved these changes
Jul 9, 2020
|
|
||
| // Client | ||
| opts := []option.ClientOption{option.WithUserAgent(useragent.String())} | ||
| if credentialsFile := c["credentials_file"]; credentialsFile != "" { |
There was a problem hiding this comment.
@kalafut this might be fine to remove since we've had this notice for ~2yrs, but we should call this out in the changelog.
|
@calvn updated - PTAL. |
calvn
added a commit
that referenced
this pull request
Jul 9, 2020
* physical/gcs: use separate client for updating locks * Address review comments Co-authored-by: Calvin Leung Huang <[email protected]>
calvn
added a commit
that referenced
this pull request
Jul 9, 2020
* physical/gcs: use separate client for updating locks * Address review comments Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Seth Vargo <[email protected]>
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* physical/gcs: use separate client for updating locks * Address review comments Co-authored-by: Calvin Leung Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same rationale and design as #9423.