Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pki: Allow to use not only one variable during templating in allowed_domains #9498

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

qk4l
Copy link
Contributor

@qk4l qk4l commented Jul 16, 2020

Improve #8509 PR.
Now it's possible to use not only pure variable in allowed_domains but also combinations of other ones or domain suffices.

@qk4l qk4l changed the title pki: Allow to use not only one variable during templating in allowed_domains #8509 pki: Allow to use not only one variable during templating in allowed_domains Jul 16, 2020
@andrejvanderzee
Copy link
Contributor

Improve #8509 PR.
Now it's possible to use not only pure variable in allowed_domains but also combinations of other ones or domain suffices.

Looks good to me! Good improvement.

@calvn calvn added this to the 1.5.1 milestone Jul 20, 2020
@calvn calvn merged commit ed32a05 into hashicorp:master Aug 17, 2020
calvn added a commit that referenced this pull request Aug 17, 2020
catsby added a commit that referenced this pull request Aug 18, 2020
* master:
  Add a section to the MySQL secrets plugin docs about x509 (#9757)
  Update documentation for MySQL Secrets Engine (#9671)
  Conditionally overwrite TLS parameters for MySQL secrets engine (#9729)
  Correctly mark Cassandra as not supporting static roles (#9750)
  changelog++
  pki: Allow to use not only one variable during templating in allowed_domains #8509 (#9498)
  agent/templates: update consul-template to v0.25.1 (#9626)
  Restoring the example policies for blocking sha1 (#9677)
  changelog++
  changelog++
  Document the new SSH signing algorithm option. (#9197)
  CHANGELOG-+
  CHANGELOG++
  Trail of bits 018 (#9674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants