plugin: fix process leak when Setup() fails #9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've noticed some leftover processes from vault plugins on our boxes. Some of them were even left over from previous instances of the service and reparented to init. This could cause issues if too many of them accumulate. When running with TRACE logging the logs showed that there was an error return by the call to Setup() the plugin. Looking through the code it looks like we do not call Cleanup() in that case.
|
|
|
Sorry, still CLA issues it seems. I'm going to override it. |
ncabatoff
pushed a commit
that referenced
this pull request
Jul 22, 2020
We've noticed some leftover processes from vault plugins on our boxes. Some of them were even left over from previous instances of the service and reparented to init. This could cause issues if too many of them accumulate. When running with TRACE logging the logs showed that there was an error return by the call to Setup() the plugin. Looking through the code it looks like we do not call Cleanup() in that case. Co-authored-by: Sorin Dumitru <[email protected]>
ncabatoff
added a commit
that referenced
this pull request
Jul 22, 2020
We've noticed some leftover processes from vault plugins on our boxes. Some of them were even left over from previous instances of the service and reparented to init. This could cause issues if too many of them accumulate. When running with TRACE logging the logs showed that there was an error return by the call to Setup() the plugin. Looking through the code it looks like we do not call Cleanup() in that case. Co-authored-by: Sorin Dumitru <[email protected]>
|
Thank you for solving this @sorindumitru ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed some leftover processes from vault plugins on our boxes. Some
of them were even left over from previous instances of the service and reparented
to init. This could cause issues if too many of them accumulate.
When running with TRACE logging the logs showed that there was an error return by
the call to Setup() the plugin. Looking through the code it looks like we do not
call Cleanup() in that case.