agent/auth/kerberos: add disable_fast_negotiation #9892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
changed the title
calvn
reviewed
Sep 4, 2020
calvn
approved these changes
Sep 4, 2020
|
I was looking at the docs on https://www.vaultproject.io/docs/agent/autoauth/methods/kerberos, and it seems that the params are missing indicators on the type and whether the param is optional. Might be a good opportunity to add them in as well, e.g. |
|
@calvn I'll follow up with a PR to fix the documentation. Good catch! |
calvn
reviewed
Sep 4, 2020
Co-authored-by: Calvin Leung Huang <[email protected]>
jasonodonnell
added a commit
that referenced
this pull request
Sep 4, 2020
* agent/auth/kerberos: add disable_fast_negotiation * simplify test * Update command/agent/auth/kerberos/kerberos_test.go Co-authored-by: Calvin Leung Huang <[email protected]> * simplify tests Co-authored-by: Calvin Leung Huang <[email protected]>
jasonodonnell
added a commit
that referenced
this pull request
Sep 4, 2020
* agent/auth/kerberos: add disable_fast_negotiation * simplify test * Update command/agent/auth/kerberos/kerberos_test.go Co-authored-by: Calvin Leung Huang <[email protected]> * simplify tests Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A documented parameter
disable_fast_negotiationwasn't being configured on the Kerberos auth-method, resulting in the boolean always being false. This adds proper support to override the value.Fixes #9567