Don't open a raft snapshot file until we have a successful snapshot response. #9894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Sep 4, 2020
| } | ||
| defer snapFile.Close() | ||
| defer w.Close() |
There was a problem hiding this comment.
I know this was in the original code, but isn't this a case where we really should be checking the result of the Close call?
There was a problem hiding this comment.
Sure? It makes the code a little uglier but what the heck.
ncabatoff
reviewed
Sep 4, 2020
|
|
||
| type lazyOpenWriter struct { | ||
| openFunc func() (io.WriteCloser, error) | ||
| writer io.WriteCloser |
There was a problem hiding this comment.
It makes me a little uncomfortable that this isn't thread/data-race safe, but it looks like it won't break anything in the existing Sys.RaftSnapshot implementation.
There was a problem hiding this comment.
Yeah, my thought was this local, unexportable writer is only used in the one case. If it were reusable I'd stick a mutex in it.
ncabatoff
approved these changes
Sep 4, 2020
|
Looks good! |
sgmiller
added a commit
that referenced
this pull request
Sep 14, 2020
…esponse. (#9894) * Don't open the snapshot file until we have a successful response * Check the success of Close if nothing else errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a lazy writer which only opens the file once data starts being
written to it, e.g. the snapshot request has succeeded. This will prevent
opening 0 byte files or clobbering existing files on error.