-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup integration testing #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will let @aeschright review the TypeScript details but these look sensible on first sight to me and I'm 💯 👍 for improving test coverage in general, so thank you for the work!
The only thing I'm worried about is bundling the 30M provider binary in the extension repo. I assume (hope) that it at least doesn't get included in the package distributed through the Marketplace, but even then my experience is that such technical debt is nearly impossible to address later. i.e. git history is immutable and we'll have to live with that decision practically forever.
Would calling init
as part of the test complicate things a lot?
@radeksimko great point, that was included mostly by accident, I will amend the setup to calling init as part of the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fix eslint suggestions
Add items to vscodeignore
8b44d3c
to
c363cd7
Compare
case 'x64': | ||
arch = 'amd64' | ||
break; | ||
case 'x32': | ||
case 'ia32': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
32bit installs were not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This PR sets up helpers and folder structure for integration testing. The example test, tests document symbols which lands in hashicorp/terraform-ls#265.