Use version JSON output of LS during installation #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschright
suggested changes
Feb 16, 2021
Co-authored-by: Audrey Eschright <[email protected]>
radeksimko
force-pushed
the
ls-version-json
branch
4 times, most recently
from
d98d5cb to
cfd255c
Compare
radeksimko
force-pushed
the
ls-version-json
branch
from
cfd255c to
d814e5c
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the extension leverage a new flag introduced in LS 0.13.0 via hashicorp/terraform-ls#386 so that we can merge and release hashicorp/terraform-ls#407
The usual disclaimer of my TS/JS skills applies here - i.e. any criticism is welcomed 😄